Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exit, improve baseimage (v4) #257

Merged
merged 10 commits into from
Jan 14, 2021
Merged

Fix exit, improve baseimage (v4) #257

merged 10 commits into from
Jan 14, 2021

Conversation

ppizarror
Copy link
Owner

@ppizarror ppizarror commented Jan 14, 2021

  • Fixes Menu Quit Error : SystemExit on VS Code #251, BaseImage Spam #252.
  • Improves docs.
  • Added BaseImage methods get_drawing_mode, set_drawing_mode, get_drawing_offset, and set_drawing_offset.
  • New PYGAME_WINDOWCLOSE event locals.
  • Fix several typing issues.
  • Removed **kwargs from Menu constructor.
  • Renamed touchscreen_enabled to touchscreen in Menu constructor.
  • Improve computation of max/min widget position.
  • Improved widget positioning on Menu centering.
  • New Menu method get_height and set_title.
  • New MenuBar widget method get_title_offset.
  • Fixed ScrollBar constructor parameter onchange.

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #257 (4becb23) into master (6707e1a) will increase coverage by 0.48%.
The diff coverage is 91.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   86.72%   87.20%   +0.48%     
==========================================
  Files          46       45       -1     
  Lines        5332     5376      +44     
==========================================
+ Hits         4624     4688      +64     
+ Misses        708      688      -20     
Impacted Files Coverage Δ
pygame_menu/__init__.py 100.00% <ø> (ø)
pygame_menu/scrollarea.py 80.24% <ø> (+3.70%) ⬆️
pygame_menu/sound.py 86.54% <ø> (ø)
pygame_menu/themes.py 87.27% <0.00%> (ø)
pygame_menu/utils.py 100.00% <ø> (ø)
pygame_menu/widgets/widget/button.py 100.00% <ø> (ø)
pygame_menu/widgets/widget/colorinput.py 93.57% <ø> (ø)
pygame_menu/widgets/widget/image.py 94.33% <ø> (ø)
pygame_menu/widgets/widget/label.py 95.65% <ø> (ø)
pygame_menu/widgets/widget/none.py 98.70% <ø> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6707e1a...4becb23. Read the comment docs.

@ppizarror ppizarror merged commit f28f984 into master Jan 14, 2021
@ppizarror ppizarror deleted the fix-exit branch January 14, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu Quit Error : SystemExit on VS Code
1 participant