Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency:Updated build-script for jax #5368

Open
wants to merge 3 commits into
base: python-ecosystem
Choose a base branch
from
Open

Currency:Updated build-script for jax #5368

wants to merge 3 commits into from

Conversation

vinodk99
Copy link
Contributor

Checklist

  • Have you checked and followed all the points mention in the CONTRIBUTING.MD
  • Have you validated script on UBI 9 container
  • Did you run the script(s) on fresh container with set -e option enabled and observe success ?
  • Did you have Legal approvals for patch files ?

@vinodk99 vinodk99 marked this pull request as ready for review January 29, 2025 08:36
nikhil-kalbande
nikhil-kalbande requested changes Jan 29, 2025
View reviewed changes
j/jax/jax_ubi_9.3.sh Outdated
@@ -20,7 +20,7 @@
PACKAGE_NAME=jax
PACKAGE_VERSION=${1:-jax-v0.4.7}
PACKAGE_URL=https://github.com/jax-ml/jax

PACKAGE_DIR=/jax
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be ./jax or only jax

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhil-kalbande addressed review comments

shubham-dayma-ibm
shubham-dayma-ibm approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@shubham-dayma-ibm shubham-dayma-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinodk99 hope wheels will be created from wrapper script

@vinodk99
Copy link
Contributor Author

vinodk99 commented Feb 5, 2025

@vinodk99 hope wheels will be created from wrapper script

yes @shubham-dayma-ibm vaildated this build-script with wrapper script on local vm also wheels are getting created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhil-kalbande nikhil-kalbande nikhil-kalbande requested changes

@shubham-dayma-ibm shubham-dayma-ibm shubham-dayma-ibm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinodk99 @nikhil-kalbande @shubham-dayma-ibm