Currency: Created build script and build_info.json for pandas #5366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vivek8123 <[email protected]>
shubham-dayma-ibm
requested changes
Feb 4, 2025
| "docker_build": false, | ||
| "validate_build_script": true, | ||
| "use_non_root_user": false, | ||
| "wheel_build" : true, |
There was a problem hiding this comment.
Why wheel_build was removed? This is a python-eco-system package
| "v1.*.*": { | ||
| "build_script": "pandas_1.5.3_ubi_9.3.sh" | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't see any mapping fro 1.5.3 but we got build-script for same
| PACKAGE_NAME=pandas | ||
| PACKAGE_VERSION=${1:-v2.1.1} | ||
| PACKAGE_URL=https://github.com/pandas-dev/pandas.git | ||
|
|
There was a problem hiding this comment.
PACKAGE_DIR variable missing
Signed-off-by: vivek8123 <[email protected]>
Signed-off-by: vivek8123 <[email protected]>
Signed-off-by: vivek8123 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
set -eoption enabled and observe success ?