Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymous fix, connection limiter, and chroot selection #228

Merged

Conversation

Xavron
Copy link

@Xavron Xavron commented Apr 27, 2024

Important - Requires pull requests to be applied before this:

Closes:

Anonymous improvements and fixes

Some quick notes:

  • Moves enable anonymous setting into its own Activity and adds chroot selection and user set limit
  • Fixes anonymous failure to work along side multi users scoped storage
  • Connection login for limit determined in CmdPass where pre-existing anonymous pass check was done
  • Tested on Android 6, Android 7.1.1, Android 14
  • Adds logs to new logging to show current and max anonymous connected clients
  • Deduplicated chroot picker as there would have been 3 duplications (but left orig alone)
  • Blocked enabling anonymous via animation on anonymous chroot [to set chroot 1st] to avoid problems - scoped requires user chosen permission, and because of multi choice, a known static default can't be chosen so this is a good safety mechanism to keep the train on the correct track and avoid failures.
  • Anonymous still has singular chroot here. Just that it is now user selectable
  • Uses AtomicInteger for the limit count to promote better multi thread use
  • Users with enabled anonymous on app update should be good (File gets set to orig location and scoped is blocked until chroot is set as a 2nd safety mechanism in the event the train gets on the tracks as it would be the wrong tracks for scoped)

@Xavron
Copy link
Author

Xavron commented Jun 5, 2024

Issue seen. Some of the anonymous UI text is difficult to see with light theme.

@ppareit ppareit merged commit 025cefc into ppareit:master Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants