Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Like (~=) operator token error on 5.6.7-1.0.1 #81

Closed
jcsims opened this issue Jul 10, 2018 · 9 comments
Closed

Like (~=) operator token error on 5.6.7-1.0.1 #81

jcsims opened this issue Jul 10, 2018 · 9 comments

Comments

@jcsims
Copy link

jcsims commented Jul 10, 2018

Plugin version:
5.6.7-1.0.1

Kibana version:
5.6.7

Plugins installed:
nested-fields-support, x-pack

Description of the problem including expected versus actual behavior:
Using a query with the like operator (~=) is failing in the Discover window, giving an error:
Unexpected token { in JSON at position 25 (position changes, this particular error is from the query host ~= "*" as an example).

Steps to reproduce:

  1. Open the Discover pane, on an index pattern with nested support turned on
  2. Type in any query using the ~= operator
  3. Notice the error message

Errors in browser console (if relevant):
None

@ppadovani ppadovani added the bug label Jul 12, 2018
@ppadovani
Copy link
Owner

I'll be focusing time this weekend on new releases and bugs, so I should be able to take a look at this then.

@jcsims
Copy link
Author

jcsims commented Jul 23, 2018

@ppadovani were you able to look into this? I'm trying to make some time this week to look into this bug.

@ppadovani
Copy link
Owner

Sorry, the port to 6.3 has taken more time than initially thought due to some of the re-org of the Kibana code... I should have 6.3 wrapped up this weekend.

If you would like to look into this and submit a pull request that would be fantastic. If not, I don't see any reason why I can't knock this out this weekend as well.

@ppadovani
Copy link
Owner

I took a quick look at this in the 6.3 release I'm working on, and it seems to be working fine. I can use this query against my test data without an issue: cars.color~="*".

If you don't submit a pull request before this weekend, I should be able to look at this at your specific release level.

@ppadovani
Copy link
Owner

Looks like a bug in the parser:

{"nested":{"path":"cars","query":{"bool":{"filter":{"wildcard":{"cars.color":"a"}}{"match_phrase":{"cars.color":"a"}}}}}}

Both a filter and match_phrase but without a separating comma... not sure the match_phrase should be there... this may have been introduced by a back port of a previous fix. This shouldn't take long to resolve.

ppadovani pushed a commit that referenced this issue Jul 26, 2018
@ppadovani
Copy link
Owner

Fixed and released.

@ppadovani
Copy link
Owner

Ooops... I want to leave this open to verify other releases and/or fix them if I propagated this bug.

@jcsims
Copy link
Author

jcsims commented Jul 26, 2018

Thanks, will try to get this verified on my end today.

ppadovani pushed a commit that referenced this issue Jul 28, 2018
(cherry picked from commit f3e56b9)
ppadovani pushed a commit that referenced this issue Jul 28, 2018
(cherry picked from commit f3e56b9)

(cherry picked from commit 2f6c544)
ppadovani pushed a commit that referenced this issue Jul 28, 2018
(cherry picked from commit f3e56b9)

(cherry picked from commit 2f6c544)

(cherry picked from commit 317111c)
ppadovani pushed a commit that referenced this issue Jul 28, 2018
(cherry picked from commit f3e56b9)

(cherry picked from commit 2f6c544)

(cherry picked from commit 317111c)

(cherry picked from commit 59f38b1)
ppadovani pushed a commit that referenced this issue Jul 28, 2018
(cherry picked from commit f3e56b9)

(cherry picked from commit 2f6c544)

(cherry picked from commit 317111c)

(cherry picked from commit 59f38b1)

(cherry picked from commit f17bace)
ppadovani pushed a commit that referenced this issue Jul 28, 2018
(cherry picked from commit f3e56b9)

(cherry picked from commit 2f6c544)

(cherry picked from commit 317111c)

(cherry picked from commit 59f38b1)

(cherry picked from commit f17bace)

(cherry picked from commit ebf2cdb)
ppadovani pushed a commit that referenced this issue Jul 29, 2018
ppadovani pushed a commit that referenced this issue Jul 29, 2018
(cherry picked from commit aa761b4)
ppadovani pushed a commit that referenced this issue Jul 29, 2018
(cherry picked from commit aa761b4)

(cherry picked from commit 71d6486)
ppadovani pushed a commit that referenced this issue Jul 29, 2018
(cherry picked from commit aa761b4)

(cherry picked from commit 71d6486)

(cherry picked from commit e7b7cf6)
ppadovani pushed a commit that referenced this issue Jul 29, 2018
(cherry picked from commit aa761b4)

(cherry picked from commit 71d6486)

(cherry picked from commit e7b7cf6)

(cherry picked from commit aecf125)

(cherry picked from commit b69b3ca)
ppadovani pushed a commit that referenced this issue Jul 29, 2018
(cherry picked from commit aa761b4)

(cherry picked from commit 71d6486)

(cherry picked from commit e7b7cf6)

(cherry picked from commit aecf125)
ppadovani pushed a commit that referenced this issue Jul 29, 2018
(cherry picked from commit aa761b4)

(cherry picked from commit 71d6486)

(cherry picked from commit e7b7cf6)

(cherry picked from commit aecf125)

(cherry picked from commit b69b3ca)

(cherry picked from commit 58d74a5)
ppadovani pushed a commit that referenced this issue Jul 29, 2018
(cherry picked from commit aa761b4)

(cherry picked from commit 71d6486)

(cherry picked from commit e7b7cf6)

(cherry picked from commit aecf125)

(cherry picked from commit b69b3ca)

(cherry picked from commit 58d74a5)

(cherry picked from commit f035986)
@ppadovani
Copy link
Owner

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants