Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range filter not generating nested queries in Kibana 6.2.2 #59

Closed
erkserkserks opened this issue Apr 12, 2018 · 6 comments
Closed

Range filter not generating nested queries in Kibana 6.2.2 #59

erkserkserks opened this issue Apr 12, 2018 · 6 comments

Comments

@erkserkserks
Copy link

Plugin version:
5.6.6-1.0.2, 6.2.2-1.0.3

Kibana version:
5.6.6, 6.2.2

Plugins installed:
KNQL only

Description of the problem including expected versus actual behavior:
The test data was generated using scripts/nested-support/genData.py

In Kibana 5.6.6, applying range filters does the right thing and produces a nested query.
In Kibana 6.2.2, applying range filters does the wrong thing and does not produce a nested query.

Kibana 5.6.6 does the right thing:
kibana_5 6 6_before
kibana_5 6 6_after

Kibana 6.2.2 does the wrong thing:
kibana_6 2 2_before
kibana_6 2 2_after

This also happens in discover.
Right thing:
kibana_5 6 6_discover
Wrong thing:
kibana_6 2 2_discover

While investigating this, I also found that some filters (built using the "Add a filter" UI) work only in certain versions of Kibana:

  • is - Works in Kibana 5 and 6
  • is one of - Does not work in Kibana 5 nor 6
  • is between - Works in Kibana 5, does not work in 6
  • exists - Does not work in Kibana 5, works in 6
@ppadovani
Copy link
Owner

Now THIS is a bug report! Many thanks for the details. I should be able to resolve most of these in the next day or so.

@ppadovani
Copy link
Owner

Ok.. There was a major update in Kibana that happened from 5.x to 6.x, and it looks like the work I did on range filters did not make it... should be fixed in the latest 6.2.2-1.04.

Please take a look if it solves the issue, please update this issue, but don't close it. I'll use this to port the fix to other releases, and close this when done.

@erkserkserks
Copy link
Author

Wow, thanks for the quick response! I can confirm that it fixes the range filter issue :)

ppadovani pushed a commit that referenced this issue Apr 26, 2018
(cherry picked from commit 9a92dd3)

Fix and release #65

(cherry picked from commit 2f4eb66)

(cherry picked from commit 7194143)

(cherry picked from commit cdcc898)

(cherry picked from commit 1e65cf7)
ppadovani pushed a commit that referenced this issue Apr 28, 2018
(cherry picked from commit 9a92dd3)

Fix and release #65

(cherry picked from commit 2f4eb66)

(cherry picked from commit 7194143)

(cherry picked from commit cdcc898)

(cherry picked from commit 1e65cf7)

(cherry picked from commit 5d86f13)
@ppadovani
Copy link
Owner

Back ported to all supported 6.X+++ releases

ppadovani pushed a commit that referenced this issue May 5, 2018
@ppadovani
Copy link
Owner

Ported to: 5.6.7, 5.6.8 and 5.6.9

ppadovani pushed a commit that referenced this issue May 6, 2018
(cherry picked from commit 853ba49)

Fix field format issue, update to new release

(cherry picked from commit 6faea74)
ppadovani pushed a commit that referenced this issue May 6, 2018
(cherry picked from commit 853ba49)

Fix field format issue, update to new release

(cherry picked from commit 6faea74)

(cherry picked from commit dc06ba9)
ppadovani pushed a commit that referenced this issue May 6, 2018
(cherry picked from commit 853ba49)

Fix field format issue, update to new release

(cherry picked from commit 6faea74)

(cherry picked from commit dc06ba9)

(cherry picked from commit 5b7bba4)
ppadovani pushed a commit that referenced this issue May 6, 2018
(cherry picked from commit 853ba49)

Fix field format issue, update to new release

(cherry picked from commit 6faea74)

(cherry picked from commit dc06ba9)

(cherry picked from commit 5b7bba4)

(cherry picked from commit 97ad9f9)
@ppadovani
Copy link
Owner

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants