-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor resource cloud_connection data source and documentation #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few typos and reordering issue
@@ -195,7 +194,7 @@ func testAccCheckIBMPICloudConnectionNetworkUpdateConfig(name string) string { | |||
} | |||
|
|||
func TestAccIBMPICloudConnectionClassic(t *testing.T) { | |||
name := fmt.Sprintf("tf-cloudconnection-%d", acctest.RandIntRange(10, 100)) | |||
name := fmt.Sprintf("tf-cloudconnection-%d", accteinstanceRandIntRange(10, 100)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acctest.RandIntRange
@@ -230,7 +229,7 @@ func testAccCheckIBMPICloudConnectionClassicConfig(name string) string { | |||
} | |||
|
|||
func TestAccIBMPICloudConnectionVPC(t *testing.T) { | |||
name := fmt.Sprintf("tf-cloudconnection-%d", acctest.RandIntRange(10, 100)) | |||
name := fmt.Sprintf("tf-cloudconnection-%d", accteinstanceRandIntRange(10, 100)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acctest.RandIntRange
@@ -269,7 +268,7 @@ func testAccCheckIBMPICloudConnectionVPCConfig(name string) string { | |||
} | |||
|
|||
func TestAccIBMPICloudConnectionTransitGateway(t *testing.T) { | |||
name := fmt.Sprintf("tf-cloudconnection-%d", acctest.RandIntRange(10, 100)) | |||
name := fmt.Sprintf("tf-cloudconnection-%d", accteinstanceRandIntRange(10, 100)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acctest.RandIntRange
Co-authored-by: michaelkad <[email protected]>
Co-authored-by: michaelkad <[email protected]>
Co-authored-by: michaelkad <[email protected]>
Co-authored-by: michaelkad <[email protected]>
Co-authored-by: michaelkad <[email protected]>
opened #126 |
Community Note
Relates OR Closes #0000
Output from acceptance testing: