Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor resource cloud_connection data source and documentation #63

Closed
wants to merge 11 commits into from

Conversation

Diptipowervs
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@Diptipowervs Diptipowervs changed the title Refactor cloud_connection data source and documentation Refactor resource cloud_connection data source and documentation Feb 21, 2024
@Diptipowervs Diptipowervs requested a review from michaelkad March 8, 2024 03:07
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few typos and reordering issue

@@ -195,7 +194,7 @@ func testAccCheckIBMPICloudConnectionNetworkUpdateConfig(name string) string {
}

func TestAccIBMPICloudConnectionClassic(t *testing.T) {
name := fmt.Sprintf("tf-cloudconnection-%d", acctest.RandIntRange(10, 100))
name := fmt.Sprintf("tf-cloudconnection-%d", accteinstanceRandIntRange(10, 100))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acctest.RandIntRange

@@ -230,7 +229,7 @@ func testAccCheckIBMPICloudConnectionClassicConfig(name string) string {
}

func TestAccIBMPICloudConnectionVPC(t *testing.T) {
name := fmt.Sprintf("tf-cloudconnection-%d", acctest.RandIntRange(10, 100))
name := fmt.Sprintf("tf-cloudconnection-%d", accteinstanceRandIntRange(10, 100))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acctest.RandIntRange

@@ -269,7 +268,7 @@ func testAccCheckIBMPICloudConnectionVPCConfig(name string) string {
}

func TestAccIBMPICloudConnectionTransitGateway(t *testing.T) {
name := fmt.Sprintf("tf-cloudconnection-%d", acctest.RandIntRange(10, 100))
name := fmt.Sprintf("tf-cloudconnection-%d", accteinstanceRandIntRange(10, 100))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acctest.RandIntRange

@michaelkad
Copy link
Collaborator

opened #126

@michaelkad michaelkad closed this May 28, 2024
@michaelkad michaelkad deleted the cloud_connection branch September 6, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants