Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sap profile data source and documentation #35

Closed
wants to merge 6 commits into from
Closed

Refactor sap profile data source and documentation #35

wants to merge 6 commits into from

Conversation

Diptipowervs
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@Diptipowervs Diptipowervs changed the title Catalog Refactor sap profile data source and documentation Refactor sap profile data source and documentation Dec 31, 2023
ismirlia
ismirlia previously approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@ismirlia ismirlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, wait for Michael's approval before opening PR in main terraform provider repo.

@michaelkad
Copy link
Collaborator

@Diptipowervs could you resolve ibm_pi_constants.go conflicts?

@Diptipowervs
Copy link
Author

PR raised in main repo

@michaelkad michaelkad deleted the sap-profile-refactor branch May 28, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismirlia ismirlia ismirlia left review comments

@michaelkad michaelkad Awaiting requested review from michaelkad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Diptipowervs @michaelkad @ismirlia