implement: default pattern

[azu]

ref #8

If the user didn't set directories.test, use 'test/**/*.js' as default pattern.

[yosuke-furukawa]

僕のコミットをムダにしないために、いくつかレビューコメント残しておきます。

[twada]

@yosuke-furukawa++

[yosuke-furukawa]

existsSync is deprecated near the future.
if the package.json is not found, you don't require in line 6.
so the check is meaningless.

EDIT: sorry, scratch that. I misunderstood this specification.
However existsSync is not needed.

[yosuke-furukawa]

面倒なので日本語で。
v0.10とかだとaccessSyncもないから今のところはexsitsSyncでいいような気がしてきました。
真面目にやるならこうですかね。

var existsSync = fs.accessSync ? fs.accessSync : fs.existsSync;

// ...

 if (dirName !== packageName && existsSync(pather.join(dir, 'package.json'))) {
  // ...
}

see: nodejs/node#257

まぁまだiojsでもexistsSyncはdeprecatedにはなっていないので、参考までに。

[yosuke-furukawa]

I think default value should not define in this function.

• before

function getTestDirFromPkg(pkg) {
    if (pkg &&
        typeof pkg.directories === 'object' &&
        typeof pkg.directories.test === 'string') {
        return normalizeDir(pkg.directories.test);
    }
    return "test/";
}

• after

var defaultTestDir = "test/";
function getTestDirFromPkg(pkg) {
    if (pkg &&
        typeof pkg.directories === 'object' &&
        typeof pkg.directories.test === 'string') {
        return normalizeDir(pkg.directories.test);
    }
    return defaultTestDir;
}

[yosuke-furukawa]

add a test case when pkg.directories is undefined.

[azu]

@yosuke-furukawa Thanks for review! I'v fixed.

[yosuke-furukawa]

Thank you for the quick fixing!!