fix evm test inputs #851
Merged
fix evm test inputs #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
reviewed
Dec 18, 2023
| @@ -124,21 +124,21 @@ fn test_password() { | |||
| mstore(0, 666) | |||
| return(0, 32) | |||
| */ | |||
| /* | |||
| static BYTECODE: &str = "61029a60005260206000f3"; | |||
chriseth
previously approved these changes
Dec 18, 2023
leonardoalt
force-pushed
the
fix-evm-dec
branch
from
e84b9d8 to
9710ba8
Compare
|
updated this PR to run the evm test with the slow tests, let's see |
|
yea this is still too much for our CI... |
leonardoalt
force-pushed
the
fix-evm-dec
branch
2 times, most recently
from
a32b8d7 to
88f6e71
Compare
|
I commented out the test again because of CI, but at least the test is correct now if you uncomment and run it |
leonardoalt
force-pushed
the
fix-evm-dec
branch
from
88f6e71 to
5f25ddd
Compare
|
the test is at least compiled now, hidden behind a feature. Ready for review |
|
looks good, but tests are failing |
leonardoalt
force-pushed
the
fix-evm-dec
branch
from
5f25ddd to
25295b2
Compare
leonardoalt
force-pushed
the
fix-evm-dec
branch
from
25295b2 to
11eb841
Compare
lvella
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the EVM test inputs and trying it out on our CI again. If CI fails because of OOM I'll comment the function out but will leave the updated inputs and
verify_riscv_crateadjustment.