Make ArrayLiteralExpression sugar for PIL implementation
#1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
reviewed
Jul 26, 2024
| @@ -167,14 +167,14 @@ FunctionDefinition: FunctionDefinition = { | |||
| body, | |||
| outer_var_references: Default::default() | |||
| })), | |||
| <start:@L> "=" <array:ArrayLiteralExpression> <end:@R> => FunctionDefinition::Array(array), | |||
| <start:@L> "=" <array:ArrayLiteralExpression> <end:@R> => desugar_array_literal_expression_with_sourceref(ctx.source_ref(start, end), array).into(), | |||
There was a problem hiding this comment.
I really like that this is done at parsing time already!
chriseth
reviewed
Jul 26, 2024
std/expand_fixed.asm
Outdated
| use std::result::Result; | ||
| use std::check::panic; | ||
|
|
||
| // A term in an array expression |
There was a problem hiding this comment.
Suggested change
| // A term in an array expression | |
| /// A term in an array expression |
chriseth
reviewed
Jul 26, 2024
std/expand_fixed.asm
Outdated
| } | ||
|
|
||
| // returns the total size of the repeated array in this array expression | ||
| let solve: ArrayTerm[], int -> Result<int, string> = |terms, degree| { |
There was a problem hiding this comment.
solve sounds a bit too generic for me. What about something like compute_length?
There was a problem hiding this comment.
ah, compute_length_of_repeated_part
Schaeff
force-pushed
the
use-expand-fixed
branch
from
a718b0a to
8a43f05
Compare
chriseth
reviewed
Aug 2, 2024
| @@ -15,7 +15,7 @@ namespace Main(N); | |||
|
|
|||
| // only make a call every other row, otherwise set `c` to 0 | |||
| // we do this to prevent running out of blocks in `Add` | |||
| col fixed CALL = [1, 0]*; | |||
There was a problem hiding this comment.
This change is not necessary, is it?
There was a problem hiding this comment.
We do not have the stdlib in PIL
chriseth
reviewed
Aug 2, 2024
| @@ -599,7 +599,7 @@ enum Operation<'a, T> { | |||
| struct Evaluator<'a, 'b, T: FieldElement, S: SymbolLookup<'a, T>> { | |||
| symbols: &'b mut S, | |||
| local_vars: Vec<Arc<Value<'a, T>>>, | |||
| type_args: HashMap<String, Type>, | |||
| type_args: Arc<HashMap<String, Type>>, | |||
There was a problem hiding this comment.
I don't see where this Arc is useful - am I missing something?
There was a problem hiding this comment.
powdr/pil-analyzer/src/evaluator.rs
Line 982 in a7577de
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
Extracted from @Schaeff `s #1623 --------- Co-authored-by: schaeff <[email protected]>
chriseth
reviewed
Aug 3, 2024
| } | ||
| }; | ||
|
|
||
| enum OffsetSearch { |
There was a problem hiding this comment.
This should probably get a better name.
This was referenced Aug 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
Equivalent to #1623 but in Rust Closes #1570 @georgwiese I wanted to add a test but everything I try either panics (we sometimes assume the fixed columns to be available in a single size) or runs forever (when I add fixed columns to a machine, I assume witgen keeps increasing the degree and never stops? or it picks the largest size and just takes time?) any thoughts?
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Mainly a test file to see what the JIT features are we need to support #1623 The "Add functionality benchmark" commit is the only important one here, the rest are merges from the implementing branches.
leonardoalt
pushed a commit
that referenced
this pull request
Oct 22, 2024
Mainly a test file to see what the JIT features are we need to support #1623 The "Add functionality benchmark" commit is the only important one here, the rest are merges from the implementing branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.