Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres 18 support #67

Merged
merged 1 commit into from
Dec 11, 2024
Merged

postgres 18 support #67

merged 1 commit into from
Dec 11, 2024

Conversation

RekGRpth
Copy link
Contributor

@RekGRpth RekGRpth commented Dec 11, 2024

Commit postgres/postgres@3eea7a0 removes last boolean argument from standard_ExecutorRun function.

@rjuju rjuju self-requested a review December 11, 2024 03:34
@rjuju rjuju self-assigned this Dec 11, 2024
@rjuju
Copy link
Member

rjuju commented Dec 11, 2024

Hi,

thanks for the PR. Could you improve the commit message a bit and also specify what upstream commit this is dealing with (which should be 3eea7a0c97e).

Are you actively using current pg18dev branch? It won't be released before many months so usually we tend to do a single compatibility commit a bit before the first beta release, to avoid too much changes and possibly reverted changes. It doesn't feel like this one will ever be reverted but it's still quite young so I'd rather wait a bit before working on its compatibility.

@RekGRpth
Copy link
Contributor Author

Could you improve the commit message a bit and also specify what upstream commit this is dealing with (which should be 3eea7a0c97e).

updated in PR description

@RekGRpth
Copy link
Contributor Author

Are you actively using current pg18dev branch?

No, but I'm every day syncing and test it with some extensions

@rjuju
Copy link
Member

rjuju commented Dec 11, 2024

ah I see. Well that seems like a good thing to do, and thanks a lot for including our extensions :)

@rjuju rjuju merged commit 0a1922c into powa-team:master Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants