Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setQuery and setHash #47

Merged
merged 2 commits into from
Jan 12, 2021
Merged

feat: setQuery and setHash #47

merged 2 commits into from
Jan 12, 2021

Conversation

cexbrayat
Copy link
Contributor

@cexbrayat cexbrayat commented Jan 11, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Fixes #42

@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #47 (f8d9630) into v2 (6d2829d) will increase coverage by 1.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2      #47      +/-   ##
==========================================
+ Coverage   97.95%   99.01%   +1.06%     
==========================================
  Files           5        5              
  Lines          98      102       +4     
  Branches       10       11       +1     
==========================================
+ Hits           96      101       +5     
+ Misses          2        1       -1     
Impacted Files Coverage Δ
src/router.ts 98.30% <100.00%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2829d...f8d9630. Read the comment docs.

@cexbrayat cexbrayat changed the title feat: setQuery (refs #42) feat: setQuery and setHash (fixes #42) Jan 11, 2021
@posva posva changed the title feat: setQuery and setHash (fixes #42) feat: setQuery and setHash Jan 11, 2021
@cexbrayat
Copy link
Contributor Author

@posva I amended the PR with your feedback 👍

Copy link
Owner

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit b401adf into posva:v2 Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add functions to easily set params
3 participants