Skip to content

Commit

Permalink
Drop support for node < v18
Browse files Browse the repository at this point in the history
  • Loading branch information
appurva21 committed Sep 24, 2024
1 parent e8d30d7 commit 67390ee
Show file tree
Hide file tree
Showing 10 changed files with 7,192 additions and 4,433 deletions.
293 changes: 149 additions & 144 deletions .eslintrc

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v3

- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
cache: 'npm'

- name: Install
Expand All @@ -39,10 +39,10 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v3

- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
cache: 'npm'

- name: Install
Expand All @@ -57,11 +57,11 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [10, 12]
node-version: [18, 20]
os: [ubuntu-latest, windows-latest]
include:
- coverage: true
node-version: 16
node-version: latest
os: ubuntu-latest

steps:
Expand All @@ -85,7 +85,7 @@ jobs:

- if: ${{ matrix.coverage }}
name: Upload coverage
run: npm run codecov -- -c -Z -f .coverage/coverage-final.json -F unit
run: npm run codecov -- -c -Z -f .coverage/coverage-final.json -F unit -t ${{ secrets.CODECOV_TOKEN }}

- name: Run integration tests
run: npm run test-integration
7 changes: 7 additions & 0 deletions CHANGELOG.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
unreleased:
breaking changes:
- GH-677 Dropped support for Node < v18
chores:
- GH-677 Updated ESLint rules
- GH-677 Updated dependencies

2.2.0:
date: 2024-03-13
new features:
Expand Down
2 changes: 1 addition & 1 deletion lib/allowed-globals.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable no-multi-spaces */
/* eslint-disable @stylistic/js/no-multi-spaces */
/**
* Add variables here that will be available as globals inside the scope during execution.
*
Expand Down
2 changes: 1 addition & 1 deletion lib/util.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = {
has (source, target) {
return Object.prototype.hasOwnProperty.call(source, target);
return Object.hasOwn(source, target);
},

isObject (subject) {
Expand Down
Loading

0 comments on commit 67390ee

Please sign in to comment.