Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console warning when legacy API is used #991

Merged
merged 6 commits into from
Apr 1, 2024

Conversation

coditva
Copy link
Member

@coditva coditva commented Mar 27, 2024

No description provided.

@coditva coditva force-pushed the deprecate/legacy-api-warn branch from 68b19bb to e0767cd Compare March 27, 2024 06:51
@coditva coditva changed the title Deprecate legacy sandbox APIs Add console warning when legacy API is used Mar 27, 2024
@coditva coditva force-pushed the deprecate/legacy-api-warn branch 2 times, most recently from 0960d85 to b5f04fc Compare March 27, 2024 07:56
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.65%. Comparing base (6fec074) to head (43ec007).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #991   +/-   ##
========================================
  Coverage    59.65%   59.65%           
========================================
  Files           12       12           
  Lines          575      575           
  Branches       140      140           
========================================
  Hits           343      343           
  Misses         232      232           
Flag Coverage Δ
unit 59.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coditva coditva force-pushed the deprecate/legacy-api-warn branch 2 times, most recently from c6d8559 to 4246d89 Compare March 28, 2024 11:17
@coditva coditva force-pushed the deprecate/legacy-api branch from ba8bbf4 to 2d82711 Compare March 28, 2024 11:55
@coditva coditva force-pushed the deprecate/legacy-api-warn branch from 4246d89 to 0f24c62 Compare March 28, 2024 11:56
@coditva coditva changed the base branch from deprecate/legacy-api to develop March 28, 2024 11:56
@coditva coditva force-pushed the deprecate/legacy-api-warn branch from 0359f02 to 43ec007 Compare April 1, 2024 08:53
@coditva coditva marked this pull request as ready for review April 1, 2024 08:53
@coditva coditva requested a review from codenirvana April 1, 2024 08:54
@codenirvana codenirvana merged commit a0c8ec1 into develop Apr 1, 2024
9 checks passed
@codenirvana codenirvana deleted the deprecate/legacy-api-warn branch April 1, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants