Sanitized the global scope by deleting the timers properties #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #990 +/- ##
========================================
Coverage 59.65% 59.65%
========================================
Files 12 12
Lines 575 575
Branches 140 140
========================================
Hits 343 343
Misses 232 232
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
coditva
reviewed
Mar 28, 2024
| @@ -82,13 +82,17 @@ const /** | |||
| isGlobalClearAvailable = (new Function(`return typeof clear${name} === 'function'`))(); | |||
|
|
|||
| if (isGlobalSetterAvailable) { | |||
| // eslint-disable-next-line no-new-func | |||
| timers[('set' + name)] = (new Function(`return function (fn, ms) { return set${name}(fn, ms); }`))(); | |||
There was a problem hiding this comment.
Why were we wrapping it in a function before if it was available globally?
coditva
approved these changes
Mar 28, 2024
codenirvana
added a commit
that referenced
this pull request
Apr 5, 2024
Sanitized the global scope by deleting the timers properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #605