Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for pm.execution.location #950

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Added support for pm.execution.location #950

merged 2 commits into from
Nov 18, 2023

Conversation

vedkribhu
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61e893f) 60.64% compared to head (60560f3) 60.71%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #950      +/-   ##
===========================================
+ Coverage    60.64%   60.71%   +0.07%     
===========================================
  Files           12       12              
  Lines          559      560       +1     
  Branches       135      136       +1     
===========================================
+ Hits           339      340       +1     
  Misses         220      220              
Flag Coverage Δ
unit 60.71% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/unit/sandbox-libraries/pm.test.js Outdated Show resolved Hide resolved
types/sandbox/prerequest.d.ts Outdated Show resolved Hide resolved
lib/sandbox/pmapi.js Outdated Show resolved Hide resolved
coditva
coditva previously approved these changes Oct 12, 2023
@coditva
Copy link
Member

coditva commented Oct 12, 2023

@vedkribhu Need to update the CHANGELOG.yaml

@vedkribhu vedkribhu force-pushed the feat/add-path branch 2 times, most recently from 5f5197e to 9b9c4aa Compare November 16, 2023 12:14
coditva
coditva previously approved these changes Nov 17, 2023
* @type {ExecutionLocation} - current execution path
* @instance
*/
location: _assignDefinedReadonly(execution.legacy._itemPath || [], /** @lends ExecutionLocation */ {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

execution.legacy is not the best way to accept this context. Need to expose a better interface for consumers to pass down all this information.

@appurva21 appurva21 changed the title feat(pmapi): add support to get path of current request in sandbox scripts Add support for pm.execution.location Nov 18, 2023
@appurva21 appurva21 changed the title Add support for pm.execution.location Added support for pm.execution.location Nov 18, 2023
@appurva21 appurva21 merged commit af5c60e into develop Nov 18, 2023
9 checks passed
@appurva21 appurva21 deleted the feat/add-path branch November 18, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants