Fix warnings when assertions are checked after execution

postmanlabs · Apr 2, 2024 · 19ca719 · 19ca719
1 parent f3946ba
commit 19ca719
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/lib/sandbox/postman-legacy-interface.js b/lib/sandbox/postman-legacy-interface.js
@@ -422,6 +422,8 @@ module.exports = {
 
         const legacyAPIUsage = new Set();
 
+        scope.__is_deprecation_warning_enabled = true;
+
         // wrap all globals to ensure we track their usage to show warnings
         // on access.
         LEGACY_GLOBS.forEach((key) => {
@@ -431,7 +433,7 @@ module.exports = {
 
             globalvars[key] = new Proxy(globalvars[key], {
                 set (target, prop, value) {
-                    logDeprecationWarning(key, legacyAPIUsage, console);
+                    scope.__is_deprecation_warning_enabled && logDeprecationWarning(key, legacyAPIUsage, console);
 
                     target[prop] = value;
                 },
@@ -440,17 +442,17 @@ module.exports = {
                     // special handling for postman because setNextRequest is
                     // used a lot.
                     if (key === 'postman') {
-                        logDeprecationWarning('postman.setNextRequest', legacyAPIUsage, console);
+                        scope.__is_deprecation_warning_enabled && logDeprecationWarning('postman.setNextRequest', legacyAPIUsage, console);
                     }
                     else {
-                        logDeprecationWarning(key, legacyAPIUsage, console);
+                        scope.__is_deprecation_warning_enabled && logDeprecationWarning(key, legacyAPIUsage, console);
                     }
 
                     return target[prop];
                 },
 
                 apply (target, thisArg, args) {
-                    logDeprecationWarning(key, legacyAPIUsage, console);
+                    scope.__is_deprecation_warning_enabled && logDeprecationWarning(key, legacyAPIUsage, console);
 
                     return target.apply(thisArg, args);
                 }
@@ -493,6 +495,8 @@ module.exports = {
             return;
         }
 
+        scope.__is_deprecation_warning_enabled = false;
+
         raiseAssertionEvent(scope, pmapi, onAssertion);
     },