[INC-263] Fallback to SHA-256 #11
Open
+1,121
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 15, 2020 09:38
Manager can now be initialized, and has methods to fetch directory and get a replay nonce from letsencrypt.
The LE store is supposed to store certificate keypair when it stores certificates
The retry was based on the incorrect assumption that challenge verification and finalization responses would always be 200 even if the status was not ready and instead would use the `status` field in the response to indicate whether the request needs to be retried. Now retry is solely based on the `status`, and not the response status code.
Makes it more readable, and easier to type as well
Makes more sense as the module did more than just generate keys. Also made generateKey synchronous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.