Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes console output banding #6447

Merged
merged 2 commits into from
Feb 23, 2025
Merged

Fixes console output banding #6447

merged 2 commits into from
Feb 23, 2025

Conversation

softwarenerd
Copy link
Contributor

@softwarenerd softwarenerd commented Feb 22, 2025

Description

This PR addresses #6445 by changing console output runs to be:

.output-run {
	display: inline-block;
	word-break: break-all;
}

So they are sized to the height of their containing div and not to the height of their text and they wrap.

Before this PR:

image

After this PR:

image

Tests:
@:console

Release Notes

New Features

  • N/A

Bug Fixes

QA Notes

Tests:
@:console

Copy link

github-actions bot commented Feb 22, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:console @:console

readme  valid tags

petetronic
petetronic previously approved these changes Feb 22, 2025
Copy link
Collaborator

@petetronic petetronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested your branch locally and confirmed this addressed the banding in the output.

@petetronic
Copy link
Collaborator

Confirmed wrapping now occurs for long output too

@softwarenerd softwarenerd merged commit aa00c75 into main Feb 23, 2025
9 checks passed
@softwarenerd softwarenerd deleted the fix/console-output-banding branch February 23, 2025 00:14
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants