Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary types/vscode (fix build issue) #6442

Merged
merged 2 commits into from
Feb 22, 2025
Merged

Conversation

jmcphers
Copy link
Collaborator

Addresses this build issue:

[17:44:35] Error: @types/vscode ^1.73.0 greater than engines.vscode ^1.65.0. Consider upgrade engines.vscode or use an older @types/vscode version
    at validateVSCodeTypesCompatibility (/Users/jmcphers/git/positron/build/node_modules/@vscode/vsce/out/validation.js:115:19)
    at validateManifest (/Users/jmcphers/git/positron/build/node_modules/@vscode/vsce/out/package.js:913:59)
    at async Promise.all (index 0)
    at async listFiles (/Users/jmcphers/git/positron/build/node_modules/@vscode/vsce/out/package.js:1333:22)

The fix is to remove @types/vscode from positron-assistant and get these types from Positron's internal copy instead.

Copy link

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

@jmcphers jmcphers merged commit a682776 into main Feb 22, 2025
8 checks passed
@jmcphers jmcphers deleted the bugfix/vscode-engine branch February 22, 2025 05:22
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant