Fix Python diagnostics not being cleared on document close #6141
Conversation
seeM
changed the base branch from
main
to
5739-fix-lsp-methods-not-searching-user-namespace
|
E2E Tests 🚀 |
seeM
force-pushed
the
3905-clear-diagnostics-on-close
branch
from
70947af to
3cf8840
Compare
| # This happens when a cell's language is changed from python e.g. to raw, | ||
| # see: https://github.com/posit-dev/positron/issues/4160. | ||
| if params.text_document.uri.startswith(_VSCODE_NOTEBOOK_CELL_SCHEME): | ||
| return _clear_diagnostics_debounced(server, params.text_document.uri) |
There was a problem hiding this comment.
Looks like this is reverting some of #5950?
There was a problem hiding this comment.
just empirically testing, it looks like Problems is still working as expected swapping between raw/Python/closing a notebook 💯
There was a problem hiding this comment.
Yea, this clears diagnostics when any document is closed instead of just notebook cells, although I've kept the test from #5950. It should probably have been that way from the beginning (see #6141 (comment)).
|
|
||
| with patch.object(server, "publish_diagnostics") as mock: | ||
| params = DidCloseTextDocumentParams(TextDocumentIdentifier(text_document.uri)) | ||
| positron_did_close_diagnostics(server, params) | ||
|
|
||
| # Wait for the diagnostics to be published |
There was a problem hiding this comment.
Do we not need this wait anymore?
There was a problem hiding this comment.
Nope. I checked upstream and they clear diagnostics immediately on document close. We should have always done that, but I assume not doing that was a mistake when we first set this up.
|
Will merge this after #6140. |
Addresses #3905.
Release Notes
New Features
Bug Fixes
QA Notes
See the linked issue.