add prerelease branches to the PR CI workflow #5352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-including-branches, we can add the prerelease branch pattern `prerelease/**` so that the usual PR CI is triggered when PRs are opened against prerelease branches. This is helpful for verifying backported fixes or fixes targeted for prerelease branches.
|
Backporting this change to the prerelease branches:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-including-branches, we can add the prerelease branch pattern
prerelease/**so that the usual PR CI is triggered when PRs are opened against prerelease branches.This is helpful for verifying backported fixes or fixes targeted for prerelease branches.
I noticed this when I targeted my fix for #5197 for the prerelease branch, merged it, but then ran into CI failures in my PR to bring in the same fix to main. For the patch branch PR, I manually ran the Full and Windows test suites, but missed the Python one.
QA Notes
Once this change is backported to a
prereleasebranch, PRs againstprereleasebranches should now automatically kick off the usual CI workflows that we see for PRs againstmain.This change can be tested when this commit is backported to the prerelease branches in a PR. The PR CI workflow should run.