Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connections pane disconnected state #2810

Merged
merged 11 commits into from
Apr 30, 2024
Merged

Connections pane disconnected state #2810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b0c032a
Initial work on disconnect state for the connections pane
dfalbel Apr 19, 2024
ea028ec
Add the code attribute and add docs for class attributes
dfalbel Apr 19, 2024
42ea7b7
no need for a `equals()` method
dfalbel Apr 19, 2024
eefed0f
Use host and type to find unique connections
dfalbel Apr 22, 2024
a5fd174
typo in connections
dfalbel Apr 22, 2024
2e2fb72
Apply suggestions from code review
dfalbel Apr 23, 2024
1b64ae2
Fix references to CopyError
dfalbel Apr 23, 2024
0d4df4d
Use separate inspectors for each supported connection
dfalbel Apr 24, 2024
d2d4d7b
SqlAlchemy url as string
dfalbel Apr 24, 2024
abfb9ee
Update extensions/positron-connections/src/connection.ts
dfalbel Apr 29, 2024
d96b301
Correctly match connections by their metadata
dfalbel Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions extensions/positron-connections/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,34 @@
"command": "positron.connections.refresh",
"title": "%commands.refresh.title%",
"icon": "$(refresh)"
},
{
"command": "positron.connections.removeFromHistory",
"title": "%commands.removeFromHistory.title%",
"icon": "$(trash)"
},
{
"command": "positron.connections.reopenConnection",
"title": "%commands.reopenConnection.title%",
"icon": "$(open-preview)"
},
{
"command": "positron.connections.copyCodeToClipboard",
"title": "%commands.copyCodeToClipboard.title%",
"icon": "$(clippy)"
},
{
"command": "positron.connections.clearConnectionsHistory",
"title": "%commands.clearConnectionsHistory.title%",
"icon": "$(clear-all)"
}
],
"menus": {
"view/title": [
{
"command": "positron.connections.clearConnectionsHistory"
}
],
"view/item/context": [
{
"command": "positron.connections.closeConnection",
Expand All @@ -76,6 +101,27 @@
"command": "positron.connections.refresh",
"group": "inline",
"when": "viewItem == database"
},
{
"command": "positron.connections.removeFromHistory",
"group": "inline",
"when": "viewItem =~ /disconnected/"
},
{
"command": "positron.connections.reopenConnection",
"group": "inline",
"when": "viewItem =~ /disconnected-hasCode/"
},
{
"command": "positron.connections.reopenConnection",
"group": "code",
"when": "viewItem =~ /disconnected-hasCode/",
"contextualTitle": "Connect to database"
},
{
"command": "positron.connections.copyCodeToClipboard",
"when": "viewItem =~ /disconnected-hasCode/",
"group": "code"
}
]
}
Expand Down
6 changes: 5 additions & 1 deletion extensions/positron-connections/package.nls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,9 @@
"commands.previewTable.title": "Preview Table",
"commands.previewTable.category": "Connections",
"commands.closeConnection.title": "Close Connection",
"commands.refresh.title": "Refresh connection"
"commands.refresh.title": "Refresh connection",
"commands.removeFromHistory.title": "Remove connection from history",
"commands.reopenConnection.title": "Execute connection code in the console",
"commands.copyCodeToClipboard.title": "Copy connection code to clipboard",
"commands.clearConnectionsHistory.title": "Clear connections history"
}
Loading
Loading