Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning in as_raw_html for Python 3.13 #563

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

stinodego
Copy link
Contributor

@stinodego stinodego commented Dec 14, 2024

Summary

At Polars we have an integration with great-tables. We are adding Python 3.13 support and noticed a DeprecationWarning coming from great-tables in our test suite. Looks like it comes from the as_raw_html method, which uses re.sub but with positional arguments for count and flags, which is deprecated in Python 3.13.

This was a simple fix, so I figured I'd just open a PR. Let me know if you need more context/input.

Checklist

@stinodego stinodego marked this pull request as ready for review December 14, 2024 10:32
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (4043f14) to head (8f1b188).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files          46       46           
  Lines        5381     5381           
=======================================
  Hits         4879     4879           
  Misses        502      502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machow machow self-requested a review December 16, 2024 16:27
Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM--thanks! @rich-iannone do you want to merge?

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit bc64116 into posit-dev:main Dec 16, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants