Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add test of options #53

Merged
merged 2 commits into from
Dec 5, 2023
Merged

tests: add test of options #53

merged 2 commits into from
Dec 5, 2023

Conversation

machow
Copy link
Collaborator

@machow machow commented Dec 5, 2023

This PR adds a test file for the options api with 1 test.

@machow
Copy link
Collaborator Author

machow commented Dec 5, 2023

It looks like I missed a line of code that tried accessing options in the old style, which caused one of the examples on the site to fail. I've added a fix here. @rich-iannone do you know why examples can fail without causing quarto render to fail? I'm not sure at which layer of the stack it's happening on (e.g. is a quarto thing, or great_tables thing?)

image

(Example should be fixed now!)

@machow machow requested a review from rich-iannone December 5, 2023 21:12
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machow machow merged commit f87d7ad into main Dec 5, 2023
@rich-iannone rich-iannone deleted the test-options branch December 6, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants