Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spanners_print_matrix now excludes selected cols that are in the stub #49

Merged
merged 2 commits into from
Dec 4, 2023
Merged

fix: spanners_print_matrix now excludes selected cols that are in the stub #49

merged 2 commits into from
Dec 4, 2023

Conversation

machow
Copy link
Collaborator

@machow machow commented Dec 4, 2023

This PR ensures that spanners_print_matrix does not include columns selected for a spanner, if those columns are in the stub.

For example, currency below was bumping other columns in header over:

from great_tables import GT, exibble

gt = GT(exibble, rowname_col="currency").tab_spanner("A", ["currency", "group", "row"])
image

Now it doesn't!:

image

@machow machow marked this pull request as ready for review December 4, 2023 22:13
@machow machow requested a review from rich-iannone December 4, 2023 22:13
rich-iannone
rich-iannone approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@machow machow merged commit 6fc39c0 into main Dec 4, 2023
@rich-iannone rich-iannone deleted the fix-selecting-stub-cols branch December 6, 2023 14:12
@machow machow mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rich-iannone rich-iannone rich-iannone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@machow @rich-iannone