Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mention support for Polars in the get-started section #408

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

jrycw
Copy link
Collaborator

@jrycw jrycw commented Jul 27, 2024

I suggest mentioning that Polars DataFrame is supported in the get-started section. This should be an attractive point for users.

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (7365aaa) to head (3d65e0b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files          42       42           
  Lines        4700     4700           
=======================================
  Hits         4061     4061           
  Misses        639      639           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machow
Copy link
Collaborator

machow commented Aug 6, 2024

Hey, thanks for opening and sorry for the wait 😓 -- we're wrapping up prep for a Great Tables workshop at posit::conf(), but should get back in the swing of things within the next week!

@github-actions github-actions bot temporarily deployed to docs-preview-update-docs August 26, 2024 18:17 Destroyed
@machow
Copy link
Collaborator

machow commented Aug 26, 2024

@jrycw thanks for writing this up -- I hope it's okay, I made some tweaks and consolidated the two pieces of example code into one. This is so helpful as a PR, it's nuts we've gone this long without mentioning polars support 😅

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@machow machow merged commit f819dea into posit-dev:main Aug 26, 2024
14 checks passed
@jrycw jrycw deleted the update-docs branch August 26, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants