-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(polars): fix fmt_percent issue with polars-u64-idx #388
Conversation
IMO this can only help :p. Do you mind giving a little context on how a person gets to this polars install? (Do you install with a flag, or install a special pypi package?). @rich-iannone do you mind reviewing? (seems okay to me, since it's a fallback behavior) edit: oh wait, I see from the issue it's from installing https://pypi.org/project/polars-u64-idx/ . seems like into okay fix for now imo |
yep for context, Polars as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
==========================================
- Coverage 86.48% 86.45% -0.04%
==========================================
Files 42 42
Lines 4685 4689 +4
==========================================
+ Hits 4052 4054 +2
- Misses 633 635 +2 ☔ View full report in Codecov by Sentry. |
@machow a flake8 rule has been flagged here:
|
Summary
drive-by attempt at solving the issue I created. I'm sure there's a cleaner way to write this, but it unblocks me. feel free to push to this PR/request changes/close in favor of a better solution!
Related GitHub Issues and PRs
polars-u64-idx
#387closes #387
Checklist