Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connections disconnected #320

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Connections disconnected #320

merged 1 commit into from
Apr 30, 2024

Conversation

dfalbel
Copy link
Contributor

@dfalbel dfalbel commented Apr 22, 2024

Provide additional metadata when opening a connection comm channel, to support the disconnected state implemented in posit-dev/positron#2810.

When opening a connection we now also provide:

- `host` and `type` to uniquely identify a connection on the front-end.
- `language_id` to identify the this is an R connection
- `code` so we store it forlater re-connecting
@dfalbel dfalbel requested a review from lionel- April 22, 2024 20:06
@dfalbel dfalbel marked this pull request as ready for review April 23, 2024 12:42
@dfalbel dfalbel merged commit 524972d into main Apr 30, 2024
1 check passed
@dfalbel dfalbel deleted the feature/disconnected-connections branch April 30, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants