Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed memory usage #2380

Merged
merged 3 commits into from
Nov 22, 2024
Merged

fixed memory usage #2380

merged 3 commits into from
Nov 22, 2024

Conversation

bernd-herzog
Copy link
Contributor

This pull request fixed some memory issues.

@gullradriel
Copy link
Member

Wooo, let me see that :-)

@bernd-herzog
Copy link
Contributor Author

authors_list fix => 2480 bytes saved

@gullradriel
Copy link
Member

So, it was cast and type shit for it.

@bernd-herzog
Copy link
Contributor Author

freqman_db fix => 1152 bytes saved

@bernd-herzog
Copy link
Contributor Author

tone_key fix => 896 bytes saved

@bernd-herzog bernd-herzog marked this pull request as ready for review November 21, 2024 23:04
gullradriel
gullradriel approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add it somewhere in the dev /contributor rules, use std::string_view as much as possible when strings are statics that will not change.

I would love an explanation about the using/extern things. I'm going to search for this.

Good to go, thanks :-)

@gullradriel gullradriel merged commit b108d97 into portapack-mayhem:next Nov 22, 2024
3 checks passed
@gullradriel
Copy link
Member

Ho, I see it now. It was also a hidden std::string replaced by a std::string_view

@gullradriel
Copy link
Member

Thanks @bernd-herzog :-)

LupusE added a commit to LupusE/mayhem-firmware that referenced this pull request Nov 22, 2024
@LupusE
Update generate_ui-about-simple.cpp.py
3eb8dae 
adapt changes from "fixed memory usage portapack-mayhem#2380" to the file generator.
gullradriel pushed a commit that referenced this pull request Nov 22, 2024
@LupusE
Add changes from "fixed memory usage #2380" to about_simple file gene…
280b8af 
…rator. (#2381)

* Generator for updating the about-page in PP from github.
* Rename generate_ui-about-simple.ccp.py to generate_ui-about-simple.cpp.py
* Adapt changes from "fixed memory usage #2380" to the file generator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gullradriel gullradriel gullradriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernd-herzog @gullradriel