i2c timeouts and sanity check on ppmod

firmware/common/i2cdev_ppmod.cpp

@@ -113,6 +113,10 @@ uint64_t I2cDev_PPmod::get_features_mask() {
     if (success == false) {
         return 0;
     }
+    // sanity check
+    if (mask == UINT64_MAX) {
+        return 0;
+    }
     return mask;
 }
 
@@ -124,7 +128,10 @@ std::optional<I2cDev_PPmod::device_info> I2cDev_PPmod::readDeviceInfo() {
     if (success == false) {
         return std::nullopt;
     }
-
+    // sanity check
+    if (info.application_count > 1000) {
+        return std::nullopt;
+    }
     return info;
 }
 
@@ -137,6 +144,10 @@ std::optional<I2cDev_PPmod::standalone_app_info> I2cDev_PPmod::getStandaloneAppI
     if (success == false) {
         return std::nullopt;
     }
+    // sanity check
+    if (info.binary_size == UINT32_MAX) {
+        return std::nullopt;
+    }
 
     return info;
 }

firmware/common/i2cdevmanager.cpp

@@ -131,8 +131,13 @@ void I2cDev::got_success() {
 
 bool I2cDev::i2c_read(uint8_t* reg, uint8_t reg_size, uint8_t* data, uint8_t bytes) {
     if (bytes == 0) return false;
-    if (reg_size > 0 && reg) i2cbus.transmit(addr, reg, reg_size);
-    bool ret = i2cbus.receive(addr, data, bytes);
+    bool ret = true;
+    if (reg_size > 0 && reg) ret = i2cbus.transmit(addr, reg, reg_size, 150);
+    if (!ret) {
+        got_error();
+        return false;
+    }
+    ret = i2cbus.receive(addr, data, bytes, 150);
     if (!ret)
         got_error();
     else
@@ -153,7 +158,7 @@ bool I2cDev::i2c_write(uint8_t* reg, uint8_t reg_size, uint8_t* data, uint8_t by
     // Copy the data into the buffer after the register data
     memcpy(buffer + reg_size, data, bytes);
     // Transmit the combined data
-    bool result = i2cbus.transmit(addr, buffer, total_size);
+    bool result = i2cbus.transmit(addr, buffer, total_size, 150);
     // Clean up the dynamically allocated buffer
     delete[] buffer;
     if (!result)