Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add color support for err message when compiling with ninja #2311

Merged
merged 1 commit into from
Oct 19, 2024
Merged

add color support for err message when compiling with ninja #2311

merged 1 commit into from
Oct 19, 2024

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Oct 19, 2024

No description provided.

gullradriel
gullradriel approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Tried a compilation, saw no difference using cmake/make/gcc9

@gullradriel gullradriel merged commit 9f84ccb into portapack-mayhem:next Oct 19, 2024
3 checks passed
@zxkmm zxkmm deleted the add_color branch October 20, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gullradriel gullradriel gullradriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxkmm @gullradriel