Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes for the ci workflow #33

Merged
merged 7 commits into from
Sep 19, 2024
Merged

minor fixes for the ci workflow #33

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7b03e1d
fixing typo and other improvements
yajith Sep 19, 2024
7dc6499
testing
yajith Sep 19, 2024
2bc3c06
testing
yajith Sep 19, 2024
3adfcb7
testing
yajith Sep 19, 2024
16369f4
testing
yajith Sep 19, 2024
490fd63
testing
yajith Sep 19, 2024
80a60dd
updating Dockerfile
yajith Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
testing
  • Loading branch information
@yajith
yajith committed Sep 19, 2024
commit 7dc6499c4bf936953d90c219a1923cfb87bfe477
4 changes: 2 additions & 2 deletions .github/workflows/dev.workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1
with:
driver-opts: image=moby/buildkit:v0.16.0
driver-opts: image=moby/buildkit:v0.10.6

- name: login to docker hub
run: echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u "${{ secrets.DOCKER_USERNAME }}" --password-stdin

- name: "build the image to portainer ci with PR number (portainerci/portainer-updater:pr$GITHUB_PR_NUMBER)"
- name: "build the image to portainer ci with PR number (portainerci/portainer-updater:pr${{ github.event.pull_request.number }})"
if: ${{ github.event.pull_request.number != '' }}
run: |
"${GITHUB_WORKSPACE}/build/build_and_push.sh" portainerci pr$GITHUB_PR_NUMBER
Expand Down
Loading