Remove headers from signature verification if gitlab invocation method #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankilevitch
requested changes
Aug 7, 2024
app/invokers/webhook_invoker.py
Outdated
| @@ -295,8 +297,12 @@ def validate_incoming_signature(self, msg: dict) -> bool: | |||
| return False | |||
|
|
|||
| # Remove the headers to avoid them being used in the signature verification | |||
There was a problem hiding this comment.
lets update the comment
Tankilevitch
reviewed
Aug 7, 2024
app/core/config.py
Outdated
Comment on lines
15
to
16
| load_dotenv() | ||
|
|
There was a problem hiding this comment.
I would do it if specific env variable is specified . e.g. if ENV_RUNTIME='DEBUG'
Tankilevitch
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Remove headers from signature verification if gitlab invocation method
Why - Gitlab invocation method doesn't send other headers than port's headers
Type of change
Please leave one option from the following and delete the rest: