Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Missing label when using mad-readonly-form-field-wrapper #52

Closed
Laess3r opened this issue Jan 22, 2021 · 0 comments · Fixed by #53
Closed

bug: Missing label when using mad-readonly-form-field-wrapper #52

Laess3r opened this issue Jan 22, 2021 · 0 comments · Fixed by #53
Assignees
@Laess3r
Labels
bug Something isn't working

Comments

@Laess3r
Copy link
Member

Laess3r commented Jan 22, 2021 •
edited
Loading

Bug Report

When the mad-readonly-form-field-wrapper is used, sometimes the labels are missing in the readonly mode.
This occures when the async translation pipe was slower than the rendering of the readonly-form-field.

This happens because the component only takes the labels' content during initial rendering. But the label might not be there yet at this time.

Expected Behavior

It should be taken care of async labels.
@Laess3r Laess3r added the bug Something isn't working label Jan 22, 2021
@Laess3r Laess3r self-assigned this Jan 22, 2021
Laess3r added a commit that referenced this issue Jan 22, 2021
@Laess3r
fix #52
e5ca3c1
@Laess3r Laess3r mentioned this issue Jan 22, 2021
Merged
@Laess3r Laess3r linked a pull request Jan 22, 2021 that will close this issue
Fix missing label when using mad-readonly-form-field-wrapper #53
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Laess3r Laess3r

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing label when using mad-readonly-form-field-wrapper porscheinformatik/material-addons
1 participant
@Laess3r