Expose the PostgresError type for TypeScript

[akheron]

With current index.d.ts it seems to be impossible to get hold of the PostgresError type. It would be useful for e.g. signatures of error handling functions.

Fix by exposing the type but not the class.

[Minigugus]

I think you can get rid of the Impl suffix, which differs from the actual implementation by the way 😉

[Minigugus]

Suggested change

	declare class PostgresErrorImpl extends Error {
	declare class PostgresError extends Error {

[Minigugus]

Suggested change

	type PostgresError = PostgresErrorImpl
	type PostgresError = typeof PostgresError

[Minigugus]

Suggested change

	PostgresError: typeof PostgresErrorImpl;
	PostgresError: PostgresError;

[akheron]

I don't think this is right. I need the type of PostgresError instances. typeof PostgresError gives the type of the constructor function.

[akheron]

I think the easiest way would be to move class PostgresError { ... } inside the namespace, but I guess it was left outside on purpose?

[Minigugus]

I don't think this is right. I need the type of PostgresError instances. typeof PostgresError gives the type of the constructor function.

Indeed, sorry 😆. Maybe a type PostgresErrorType = PostgresError; before the declare namespace, and type PostgresError = PostgresErrorType after? 😐

I think the easiest way would be to move class PostgresError { ... } inside the namespace, but I guess it was left outside on purpose?

Yes, because in this case it becomes possible to access the class constructor from the package exports, which is wrong: it is only accessible on the sql tag.

[akheron]

Maybe a type PostgresErrorType = PostgresError; before the declare namespace, and type PostgresError = PostgresErrorType after? 😐

Fixed like this ^

[porsager]

I guess this is good to merge - right @Minigugus ?