create beginPrepared function

[shayan-shojaei]

Added a new function called beginPrepared to support prepared transactions.

[porsager]

My idea was that .prepare() would be available on the sql transaction instance, so you would still use .begin()

Like this:

await sql.begin(async sql => {
  ...queries
  await sql.prepare(name)
})

[shayan-shojaei]

This would have been a great option if running other queries after the prepare function was an option, but considering that it's not, I would imagine this would be a more elegant option.

[porsager]

There's nothing preventing us from implementing it such that you can? sql.prepare(name) can simply be a function that caches the name and signals that instead of commit we should do prepare transaction name

[shayan-shojaei]

So your idea is that sql.prepare(name) does not instantly prepare the transaction? Instead it signals that the transaction should end with a prepared transaction?

[porsager]

The cool thing is that you'll also be able to conditionally decide if you want to prepare or commit the transaction depending on the result of queries in the transaction.

[porsager]

So your idea is that sql.prepare(name) does not instantly prepare the transaction? Instead it signals that the transaction should end with a prepared transaction?

Exactly.

[shayan-shojaei]

Yes that would be nice, I'll implement it like so.

[porsager]

Cool.. Mind adding tests and documentation for this new method?

[shayan-shojaei]

Cool.. Mind adding tests and documentation for this new method?

done

[porsager]

Looks good so far. Perhaps the test should open another connection and try to commit the prepared transaction?

[shayan-shojaei]

Looks good so far. Perhaps the test should open another connection and try to commit the prepared transaction?

Yeah I just thought of that. See if the current test would suffice.

[porsager]

🎉 perfect.. Seems we need to enable prepared transactions in the bootstrap script for tests to work.

Also - very curious what scenario you're in - needing this feature 😋 sounds exotic 🏝️

[porsager]

Add this line to bootstrap.js
exec('psql', ['-c', 'alter system set max_prepared_transactions to 10'])

[shayan-shojaei]

🎉 perfect.. Seems we need to enable prepared transactions in the bootstrap script for tests to work.

Also - very curious what scenario you're in - needing this feature yum sounds exotic desert_island

We're trying to implement distributed transactions using the 2PC method. =)

[shayan-shojaei]

Add this line to bootstrap.js exec('psql', ['-c', 'alter system set max_prepared_transactions to 10'])

I don't think this has enabled them.

[porsager]

No, seems it can only be set at start, so we need to edit postgresql.conf and restart 😐

[shayan-shojaei]

No, seems it can only be set at start, so we need to edit postgresql.conf and restart neutral_face

I think that could be handled if a line is added to the test.yml file to add that line to the postgresql.conf file at start.

[porsager]

I'd like an idempotent solution in the bootstrap.js script since I run tests most locally (and that ought to fix github as well). I'm looking into a solution ;)

[porsager]

I remember why i hated this now 😮‍💨 Doing a cross platform way of restarting the server is quite annoying 😅 I think for now saying you have to do this locally yourself is ok, and the following line to replace your's in the .yml ought to do the trick for github actions.:

sudo sed -i 's/.*max_prepared_transactions.*/max_prepared_transactions = 100/' /etc/postgresql/${{ matrix.postgres }}/main/postgresql.conf

[shayan-shojaei]

I remember why i hated this now 😮‍💨 Doing a cross platform way of restarting the server is quite annoying 😅 I think for now saying you have to do this locally yourself is ok, and the following line to replace your's in the .yml ought to do the trick for github actions.:

sudo sed -i 's/.*max_prepared_transactions.*/max_prepared_transactions = 100/' /etc/postgresql/${{ matrix.postgres }}/main/postgresql.conf

Yeah I can't think of a pretty way of doing that either. 😂

[porsager]

Everything looks good now 👏

[Minigugus]

Sorry I'm a month late... 😓 Just to report some issues that might be worth to fix (it's still on master as of now)