WIP: fix slow parsing of large messages #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The logic is philosophically the same as alt solutions in that PR 👍 |
eugene1g
reviewed
Sep 9, 2021
eugene1g
reviewed
Sep 9, 2021
lib/connection.js
Outdated
| @@ -33,6 +33,8 @@ function Connection(options = {}) { | |||
| let next = false | |||
| let statements = {} | |||
| let connect_timer | |||
| let bs = null | |||
There was a problem hiding this comment.
Maybe naming this as bufferStack or bufferQueue would help to understand what's going on 6 months later :D
There was a problem hiding this comment.
Good idea 😉 But bs is such a nice variable name 🤪
|
have no idea how it works :D but it's awesome that it improves the performance for big chunks :) Update: I've just read your comment in issue and it becomes more clear :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #207 I made this fix. I might improve the code a little before merging, but this introduces only performance improvements and no performance regressions.