Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multihost support for High Availability setups #158

Merged
merged 18 commits into from
Mar 23, 2021
Merged

Multihost support for High Availability setups #158

merged 18 commits into from
Mar 23, 2021

Conversation

porsager
Copy link
Owner

@porsager porsager commented Mar 5, 2021

Multiple hosts can be specified like in psql.

It's either done through the connection string, or through arrays in the host and port parameters.

@porsager
Copy link
Owner Author

porsager commented Mar 5, 2021

Would you mind taking a look at this @Minigugus and @stalniy ?

@Minigugus
Copy link
Contributor

I haven't tested yet but looks good to me. I can try to test it this week if you want, but I never used the postgresql's multi hosts feature, I can't promise anything.

Do you want me to update typescript types by the way?

@porsager
Copy link
Owner Author

porsager commented Mar 9, 2021

Thanks, a couple of extra eyes was fine, I've tested it ;)

Would be great to have the typescript types updated too 👍

@Minigugus
Copy link
Contributor

I corrected some problems with the types along the way.

I also have an improvement for B but I wanted your opinion before committing, since it may be a breaking change. It improves support for multi-statement queries with unsafe. It's not a big deal, it doesn't deserve another PR I think, but it's off topic for this one. Should I push this anyway?

@porsager
Copy link
Owner Author

@Minigugus looks great, thank you - are any of the unrelated type changes breaking in any way?

re: unsafe Since it's unrelated, let's just take it in another PR

@porsager porsager merged commit 16bc7db into master Mar 23, 2021
@porsager porsager deleted the multihost branch March 23, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants