Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote all columns in generated inserts, updates #57

Closed
naturalethic opened this issue Apr 16, 2020 · 2 comments
Closed

Quote all columns in generated inserts, updates #57

naturalethic opened this issue Apr 16, 2020 · 2 comments

Comments

@naturalethic
Copy link

I use camelCase for table and column names. These need to be quoted. Currently when I do something like:

    await sql`
      INSERT INTO "Address" ${sql(address)}
    `

The fields aren't being quoted.

@porsager
Copy link
Owner

That's a really good point. It's a breaking change, but also wrong if someone relied on that functionality, so let's include the fix in 2.0 which should be right around the corner.

@naturalethic
Copy link
Author

You need a hand?

porsager added a commit that referenced this issue Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants