Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing types for values() method #385

Closed
ariofrio opened this issue May 31, 2022 · 4 comments · Fixed by #393
Closed

Missing types for values() method #385

ariofrio opened this issue May 31, 2022 · 4 comments · Fixed by #393

Comments

@ariofrio
Copy link

Worse than that, IDEs actually point to Array.values(), which gives the wrong type and is quite confusing.

@Minigugus
Copy link
Contributor

Minigugus commented Jun 1, 2022

Forgot that one, sorry 😅

The fix is quite simple, but have the issue to return rows of type (string | number)[] when the row description is { a: string, b: number } for instance (no order information)

https://github.com/porsager/postgres/pull/393/files

@porsager
Copy link
Owner

porsager commented Jun 6, 2022

Hey @Minigugus - is this a fix that should be applied, or something in user land?

Minigugus added a commit to Minigugus/postgres that referenced this issue Jun 6, 2022
@Minigugus
Copy link
Contributor

Hey @Minigugus - is this a fix that should be applied, or something in user land?

Sorry I was too lazy to open a PR, but it's done now 😅: #393

porsager pushed a commit that referenced this issue Jun 6, 2022
@porsager
Copy link
Owner

porsager commented Jun 6, 2022

Thanks ! ☺️

porsager pushed a commit that referenced this issue Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants