Fix writing host and port on connection timeouts

porsager · Feb 1, 2023 · 1525f32 · 1525f32
1 parent 7e4f76d
commit 1525f32
Show file tree

Hide file tree

Showing 6 changed files with 57 additions and 0 deletions.
diff --git a/cjs/src/connection.js b/cjs/src/connection.js
@@ -339,6 +339,9 @@ function Connection(options, queues = {}, { onopen = noop, onend = noop, onclose
       return socket.connect(options.path)
 
     socket.connect(port[hostIndex], host[hostIndex])
+    socket.host = host[hostIndex]
+    socket.port = port[hostIndex]
+
     hostIndex = (hostIndex + 1) % port.length
   }
 

diff --git a/cjs/tests/index.js b/cjs/tests/index.js
@@ -1575,6 +1575,22 @@ t('connect_timeout throws proper error', async() => [
   })`select 1`.catch(e => e.code)
 ])
 
+t('connect_timeout error message includes host:port', { timeout: 20 }, async() => {
+  const connect_timeout = 0.2
+  const server = net.createServer()
+  server.listen()
+  const sql = postgres({ port: server.address().port, host: '127.0.0.1', connect_timeout })
+  const port = server.address().port
+  let err
+  await sql`select 1`.catch((e) => {
+    if (e.code !== 'CONNECT_TIMEOUT')
+      throw e
+    err = e.message
+  })
+  server.close()
+  return [["write CONNECT_TIMEOUT 127.0.0.1:", port].join(""), err]
+})
+
 t('requests works after single connect_timeout', async() => {
   let first = true
 

diff --git a/deno/src/connection.js b/deno/src/connection.js
@@ -343,6 +343,9 @@ function Connection(options, queues = {}, { onopen = noop, onend = noop, onclose
       return socket.connect(options.path)
 
     socket.connect(port[hostIndex], host[hostIndex])
+    socket.host = host[hostIndex]
+    socket.port = port[hostIndex]
+
     hostIndex = (hostIndex + 1) % port.length
   }
 

diff --git a/deno/tests/index.js b/deno/tests/index.js
@@ -1577,6 +1577,22 @@ t('connect_timeout throws proper error', async() => [
   })`select 1`.catch(e => e.code)
 ])
 
+t('connect_timeout error message includes host:port', { timeout: 20 }, async() => {
+  const connect_timeout = 0.2
+  const server = net.createServer()
+  server.listen()
+  const sql = postgres({ port: server.address().port, host: '127.0.0.1', connect_timeout })
+  const port = server.address().port
+  let err
+  await sql`select 1`.catch((e) => {
+    if (e.code !== 'CONNECT_TIMEOUT')
+      throw e
+    err = e.message
+  })
+  server.close()
+  return [["write CONNECT_TIMEOUT 127.0.0.1:", port].join(""), err]
+})
+
 t('requests works after single connect_timeout', async() => {
   let first = true
 

diff --git a/src/connection.js b/src/connection.js
@@ -339,6 +339,9 @@ function Connection(options, queues = {}, { onopen = noop, onend = noop, onclose
       return socket.connect(options.path)
 
     socket.connect(port[hostIndex], host[hostIndex])
+    socket.host = host[hostIndex]
+    socket.port = port[hostIndex]
+
     hostIndex = (hostIndex + 1) % port.length
   }
 

diff --git a/tests/index.js b/tests/index.js
@@ -1575,6 +1575,22 @@ t('connect_timeout throws proper error', async() => [
   })`select 1`.catch(e => e.code)
 ])
 
+t('connect_timeout error message includes host:port', { timeout: 20 }, async() => {
+  const connect_timeout = 0.2
+  const server = net.createServer()
+  server.listen()
+  const sql = postgres({ port: server.address().port, host: '127.0.0.1', connect_timeout })
+  const port = server.address().port
+  let err
+  await sql`select 1`.catch((e) => {
+    if (e.code !== 'CONNECT_TIMEOUT')
+      throw e
+    err = e.message
+  })
+  server.close()
+  return [["write CONNECT_TIMEOUT 127.0.0.1:", port].join(""), err]
+})
+
 t('requests works after single connect_timeout', async() => {
   let first = true