Codecov Proposal: Allow the check to succeed even if a coverage threshold is missed #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes (intermittently?) codecov has no data for either the base or head commit of a PR and can produce no coverage statistics. We don't want the GitHub checks to fail for spurious operational reasons like this, so mark these coverage checks as informational only.
illusional
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes (intermittently?) codecov has no data for either the base or head commit of a PR and can produce no coverage statistics. We don't want the GitHub checks to fail for spurious operational reasons like this, so mark these coverage checks as informational only.
For example here the base commit previously failed CI tests, and at several commits in #875 the HEAD statistics were missing so codecov/patch spuriously failed the build checks.
While it's good to pay attention to the coverage reports, I don't think we veto PRs on the basis of degraded coverage. So at least while there are intermittent spurious failures, we don't lose anything by stopping codecov from putting an ❌ on builds.