Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: frames not being filtered on page load #41

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

OmgImAlexis
Copy link
Contributor

With this change the checkbox now works correctly on page load.

@thetutlage
Copy link
Member

What was not working correctly earlier? It will be great if you can share some context and maybe a before and after screenshot

@OmgImAlexis

This comment has been minimized.

@RomainLanz
Copy link
Member

RomainLanz commented Jan 14, 2022

Hey @OmgImAlexis! 👋🏻

The issue I see with the checkbox is after checking it when you refresh, it stays checked, but the frame list is not updated according.

Is this what you are talking about?

Applying your changes does not seem to fix this issue on my machine.

youch.mp4

@OmgImAlexis

This comment has been minimized.

@RomainLanz
Copy link
Member

RomainLanz commented Jan 14, 2022

Well... not building the code will sure not make it work. 😅
Thanks!

Are you using Firefox?

@OmgImAlexis

This comment has been minimized.

@RomainLanz RomainLanz merged commit 9719d1c into poppinss:develop Jan 15, 2022
@OmgImAlexis OmgImAlexis deleted the patch-1 branch January 15, 2022 12:00
@thetutlage
Copy link
Member

The issue I see with the checkbox is after checking it when you refresh, it stays checked, but the frame list is not updated according.

@RomainLanz How can the checkbox stay checked on page refresh? Is this something exclusive to Firefox?

@RomainLanz
Copy link
Member

The issue I see with the checkbox is after checking it when you refresh, it stays checked, but the frame list is not updated according.

@RomainLanz How can the checkbox stay checked on page refresh? Is this something exclusive to Firefox?

Yes, it is!
Should we add a boolean in the session storage to have the same behavior on other browsers?

@thetutlage
Copy link
Member

Naah. It's fine, let's stick to the browser behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants