Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add gjs to DEFAULT_FLOAT_RULES #1610

Merged
merged 1 commit into from
Apr 20, 2023
Merged

re-add gjs to DEFAULT_FLOAT_RULES #1610

merged 1 commit into from
Apr 20, 2023

Conversation

n3m0-22
Copy link
Contributor

@n3m0-22 n3m0-22 commented Apr 11, 2023

This is to fix #1608 which affects Wayland, and was caused by #1605.

#1605 fixed #1056 by moving gjs from DEFAULT_FLOAT_RULES to SKIPTASKBAR_EXCEPTIONS.

By keeping gjs in both it appears to resolve both issues.

To test in X11:

There should not be any blank gjs icon showing.

To test in Wayland:

  • while logged into Wayland enable tiling
  • open a window on the first workspace
  • open a window on the second workspace

Both should now take up the whole workspace and not just half as described in #1608.

@n3m0-22 n3m0-22 marked this pull request as ready for review April 11, 2023 18:46
@n3m0-22 n3m0-22 requested review from a team April 11, 2023 18:46
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm, this fixes empty tiles in Wayland. I can still make the bug happen if I hit Super + G after logging in, then opening some apps, but that isn't a surprise.

@leviport leviport merged commit 0e09473 into master_jammy Apr 20, 2023
@leviport leviport deleted the gjs-exception branch April 20, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pop OS tiling creates empty windows with Wayland gjs file running
3 participants