Skip to content

Commit

Permalink
fix: title bar showing/hiding
Browse files Browse the repository at this point in the history
  • Loading branch information
@ghostdevv @jacobgkau
ghostdevv authored and jacobgkau committed Oct 30, 2023
1 parent 2c7ccec commit 1c5899c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/xprop.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import GLib from 'gi://GLib';
import { spawn } from 'resource:///org/gnome/shell/misc/util.js';

export var MOTIF_HINTS: string = '_MOTIF_WM_HINTS';
export var HIDE_FLAGS: string[] = ['0x2', '0x0', '0x2', '0x0', '0x0'];
export var HIDE_FLAGS: string[] = ['0x2', '0x0', '0x0', '0x0', '0x0'];
export var SHOW_FLAGS: string[] = ['0x2', '0x0', '0x1', '0x0', '0x0'];

export function get_window_role(xid: string): string | null {
Expand Down Expand Up @@ -74,7 +74,7 @@ export function get_xid(meta: Meta.Window): string | null {

export function may_decorate(xid: string): boolean {
const hints = motif_hints(xid);
return hints ? hints[2] != '0x0' : true;
return hints ? hints[2] == '0x0' || hints[2] == '0x1' : true;
}

export function motif_hints(xid: string): Array<string> | null {
Expand Down

4 comments on commit 1c5899c

@Neo-29
Copy link

@Neo-29 Neo-29 commented on 1c5899c Oct 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't work on archlinux.
No effect.when clicking on show windows titles
image
Same result ... hide or not

@jacobgkau
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neo-29 Can you confirm those windows are using server-side decorations and you are not running Wayland?

If so, please open an issue referencing the commit or its pull request instead of just making a comment (commit comments can easily get lost).

@Neo-29
Copy link

@Neo-29 Neo-29 commented on 1c5899c Oct 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neo-29 Can you confirm those windows are using server-side decorations and you are not running Wayland?

If so, please open an issue referencing the commit or its pull request instead of just making a comment (commit comments can easily get lost).

Done.
Using Wayland by the way

@jacobgkau
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neo-29 If you're using Wayland, then this feature cannot work. That's known/expected.

Please sign in to comment.