Skip to content

Commit

Permalink
net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ip…
Browse files Browse the repository at this point in the history
…v6()

The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return
false on failure.  It should not return negatives because that means
succes/true.

Fixes: fcb6aa8 ("act_ct: Support GRE offload")
Signed-off-by: Dan Carpenter <[email protected]>
Acked-by: Toshiaki Makita <[email protected]>
Link: https://lore.kernel.org/r/YpYFnbDxFl6tQ3Bn@kili
Signed-off-by: Paolo Abeni <[email protected]>
  • Loading branch information
Dan Carpenter authored and Paolo Abeni committed Jun 1, 2022
1 parent e6652a8 commit 8636003
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/sched/act_ct.c
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ tcf_ct_flow_table_fill_tuple_ipv6(struct sk_buff *skb,
break;
#endif
default:
return -1;
return false;
}

if (ip6h->hop_limit <= 1)
Expand Down

0 comments on commit 8636003

Please sign in to comment.