Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmic-panel-config has transitive dependency on smithay #4

Closed
ids1024 opened this issue Jun 29, 2022 · 4 comments
Closed

cosmic-panel-config has transitive dependency on smithay #4

ids1024 opened this issue Jun 29, 2022 · 4 comments

Comments

@ids1024
Copy link
Member

ids1024 commented Jun 29, 2022

cosmic-panel-config ends up pulling in smithay since that is a hard dependency of xdg-shell-wrapper, which cosmic-panel-config uses a few types from.

It would be good to avoid this if possible, if cosmic-panel-config is widely used in applets that have no need for smithay (trying to update it, I'm seeing complains about compiling smithay, which should be resolvable but seems unnecessary).

@ids1024
Copy link
Member Author

ids1024 commented Jun 29, 2022

Perhaps the parts that are needed in applets could ultimately be incorporated in some way in libcosmic, so that's the only library needed for applet development.

@ids1024
Copy link
Member Author

ids1024 commented Jul 5, 2022

It also depends on smithay-client-toolkit.

ids1024 added a commit to pop-os/xdg-shell-wrapper that referenced this issue Jul 5, 2022
Only depends on `wayland-protocols` and `serde`, so `cosmic-panel-config`
doesn't need to pull in so many dependencies.

pop-os/cosmic-panel#4
ids1024 added a commit to pop-os/xdg-shell-wrapper that referenced this issue Jul 5, 2022
Only depends on `wayland-protocols` and `serde`, so `cosmic-panel-config`
doesn't need to pull in so many dependencies.

pop-os/cosmic-panel#4
@ids1024
Copy link
Member Author

ids1024 commented Jul 19, 2022

This is resolved now that xdg-shell-config has been split off.

@ids1024 ids1024 closed this as completed Jul 19, 2022
@ziguana
Copy link

ziguana commented Jan 27, 2025

I'm hitting this while trying to build an applet. It's pulling in both registry+ and git+ versions of the crate, and my build system (nix's buildRustPackage) can't cope.

$ cargo tree --invert git+https://github.com/Smithay/client-toolkit#[email protected]
smithay-client-toolkit v0.19.2 (https://github.com/Smithay/client-toolkit#ca6a36e4)
└── cosmic-panel-config v0.1.0 (https://github.com/pop-os/cosmic-panel#107f597c)
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants