-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ext-image-source and ext-screencopy #365
base: master
Are you sure you want to change the base?
Conversation
It's merged now! 🎉 |
We know. Waiting for a new wayland-protocols release before we can update wayland-rs. |
wayland-protocols 1.37 was released. Seems like wayland-rs can be updated after this PR is merged: Smithay/wayland-rs#754 |
|
It would be nice if this could be supported as we are now seeing applications that can utilize this |
It might be worth noting that sway has merged support for these protocols, so we may start to see more applications use them. |
It may be easiest to support first on the client side. I've started working on client code to abstract over the cosmic-screencopy-v2 protocol and the final version of the ext protocol (which is only slightly different). If we merge support in clients first, we could just drop support for cosmic-screencopy-v2 in the compositor and replace it with ext-image-copy-capture. |
Client-side, I was prototyping a potentially better and higher-level API for screen capture to share between the cosmic components that use screencopy, but for now in pop-os/cosmic-protocols#46 I'm incrementally improving the API we have now, and making it work with ext-image-copy-capture (with a few more changes I still need to make, that branch should work for output/toplevel capture with ext-image-copy-capture). So we need to decide about workspace capture (pop-os/cosmic-protocols#47), potentially using ext-workspace-v1 (which we don't currently implement), but other than that we should be able to have our clients updated to support ext-image-copy-capture quite soon. I'll be happy to be able to test against Sway to see if there are differences in the implementations, help identify which issues are compositor bugs, etc. |
Implementation of unmerged upstream protocol ext-image-source and ext-screencopy (https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/124) based on #358.